P2pk receive wallet #1466
Open
P2pk receive wallet #1466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This replaces this right? #1053 |
Contributor
Author
yes |
Contributor
Author
|
@thesimplekid @crodas I think this is know in a decent state. I know I'm lacking tests. I want to get your opinion on the implementation before I do that. |
thesimplekid
requested changes
Dec 31, 2025
thesimplekid
reviewed
Jan 1, 2026
lescuer97
force-pushed
the
p2pk_receive_wallet
branch
from
0f325d8 to
f1f93f3
Compare
thesimplekid
reviewed
Jan 8, 2026
Collaborator
thesimplekid
left a comment
thesimplekid
left a comment
There was a problem hiding this comment.
Thanks just a few comments.
lescuer97
force-pushed
the
p2pk_receive_wallet
branch
from
cd73868 to
ccaf38a
Compare
lescuer97
force-pushed
the
p2pk_receive_wallet
branch
3 times, most recently
from
af76597 to
e4044ee
Compare
Contributor
Author
|
@thesimplekid rebased |
lescuer97
force-pushed
the
p2pk_receive_wallet
branch
from
b64cc5d to
4093b6c
Compare
Collaborator
|
ACK 4093b6c |
thesimplekid
approved these changes
Jan 15, 2026
thesimplekid
requested changes
Jan 15, 2026
lescuer97
force-pushed
the
p2pk_receive_wallet
branch
from
136ab20 to
3fccf57
Compare
lescuer97
force-pushed
the
p2pk_receive_wallet
branch
from
3fccf57 to
251b0f1
Compare
Contributor
Author
|
this commit: 57a072b changes the derivation to in accordance to cashubtc/nuts#331. plus adds tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add public key generation with counter for wallet.
Notes to the reviewers
Suggested CHANGELOG Updates
CHANGED
ADDED
REMOVED
FIXED
Checklist
just final-checkbefore committing